Sorry Olivier I thought you meant the original dm github repo... and I
totally missed the apache mirrors on github! That is great! :)
Thanks,
Raffaele
Il giorno 26/nov/2011 16:11, "Olivier Lamy" <[email protected]> ha scritto:
> 2011/11/26 Olivier Lamy <[email protected]>:
> > 2011/11/26 Raffaele P. Guidi <[email protected]>:
> >> well, the github repo is frozen at the day of the incubation start, but
> I
> >> would be pleased to update it would it be useful to anyone for this
> >
> > I miss you here. What do you mean exactly ?
> >
> > What prevent folks to fork https://github.com/apache/directmemory on
> > github (see https://github.com/olamy/directmemory/) or gitorious.org
> > (see https://gitorious.org/directmemory) then hack in a feature
> > branch.
> > And then create a pull request on github
> > (https://github.com/apache/directmemory/pull/1) This should normaly
> > generate an email to dev ml (see sample
> > http://markmail.org/message/kwa4r7l5vj7ey3ai). But it looks there is
> > an issue with incubator ml as my pull request didn't generate any
> > email. (I will ask infra)
> As you can see. Email not immediate but works in fact.
> >
> > Or create a jira link with the link on their @github or
> > @gitorious.org. If the checkbox is selected regarding ip or the guy
> > send a cla in case of significant amount of code, I don't see any
> > issues accepting such contributions.
> >
> > Perso I have asf projects setup locally with git svn and some remotes
> > on which I can push to show features I have hacked.
> >
> > IMHO it's a good workflow until native git @asf
> >
> >>
> >> On Sat, Nov 26, 2011 at 10:42 AM, Olivier Lamy <[email protected]>
> wrote:
> >>
> >>> 2011/11/26 Raffaele P. Guidi <[email protected]>:
> >>> >>> raffaele github is a private company not a scm tool it's very
> >>> different !
> >>> >
> >>> > I'm totally aware of that (believe me) but _that_ is the workflow I'm
> >>> used
> >>> > to - and the whole community should recognize that the fork->pull
> >>> workflow
> >>> > is becoming a mindset and should be recognized in his own regardless
> the
> >>> > private company behind it (that, thanks god, didn't put an IP on it).
> >>> Agree I like using it too in other oss I'm involved.
> >>> >Hope that the ASF takes this in consideration while moving to the git
> scm.
> >>> That's an other story and I don't want to feed any troll :-)
> >>>
> >>> BTW nothing prevent you to fork https://github.com/apache/directmemory
> >>> expose the new feature in a feature branch or in your master fork then
> >>> ask review.
> >>> Re integrate this in the asf scm is very easy.
> >>>
> >>>
> >>> >
> >>> > Ciao,
> >>> > R
> >>> >
> >>> > On Sat, Nov 26, 2011 at 9:29 AM, Olivier Lamy <[email protected]>
> wrote:
> >>> >
> >>> >> yup use agree create a branch and commit on it.
> >>> >> Like a *git* workflow. (raffaele github is a private company not a
> scm
> >>> >> tool it's very different ! )
> >>> >> As it everybody will se that.
> >>> >> You can do it now directly in svn (or tru git svn).
> >>> >>
> >>> >>
> >>> >> 2011/11/26 Raffaele P. Guidi <[email protected]>:
> >>> >> > Well, being used to the github workflow this feels quite natural.
> The
> >>> >> > un-natural thing is asking before doing it (just fork, branch and
> >>> make a
> >>> >> > pull request when you are done). In any case I think jira should
> be
> >>> used
> >>> >> to
> >>> >> > track bugs, ask for features and "assign" items, not to obtain an
> >>> >> > authorization to work on things. It shouldn't prevent spontaneous
> >>> coding
> >>> >> > from committers.
> >>> >> >
> >>> >> > Ciao,
> >>> >> > R
> >>> >> > Il giorno 26/nov/2011 07:55, "Tommaso Teofili" <
> >>> >> [email protected]>
> >>> >> > ha scritto:
> >>> >> >
> >>> >> >> Hi all,
> >>> >> >>
> >>> >> >> yesterday I was doing some code review on DM and my feeling is
> that
> >>> we
> >>> >> >> should do some refactoring on a couple of things:
> >>> >> >> - dependencies: I'd like to keep the dependency list size as
> low as
> >>> >> >> possible, trying to remove the dependencies that are not
> "critical"
> >>> >> (i.e.:
> >>> >> >> I wouldn't rewrite a new logger slf4j just works nicely)
> >>> >> >> - modularity: I think it'd be good if we could enhance cohesion
> and
> >>> >> >> modularity of classes; i.e. Cache and CacheService as they have
> lots
> >>> of
> >>> >> >> different methods (different contracts / responsibilities)
> >>> >> >>
> >>> >> >> I know those are a kind of high level topics but I think I could
> try
> >>> to
> >>> >> >> create a DM branch where I "propose" some dependencies to be
> removed
> >>> and
> >>> >> >> also some code refactoring.
> >>> >> >> I'm proposing that instead of opening tinier issues/tasks on Jira
> >>> since
> >>> >> I
> >>> >> >> think changes would impact lots of classes so it may be hard to
> >>> >> maintain.
> >>> >> >> What do you think?
> >>> >> >> Tommaso
> >>> >> >>
> >>> >> >
> >>> >>
> >>> >>
> >>> >>
> >>> >> --
> >>> >> Olivier Lamy
> >>> >> Talend: http://coders.talend.com
> >>> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>> >>
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>> Olivier Lamy
> >>> Talend: http://coders.talend.com
> >>> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>>
> >>
> >
> >
> >
> > --
> > Olivier Lamy
> > Talend: http://coders.talend.com
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>
>
>
> --
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
