[ 
https://issues.apache.org/jira/browse/DIRECTMEMORY-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210943#comment-13210943
 ] 

Simone Tripodi commented on DIRECTMEMORY-43:
--------------------------------------------

Michael, I had a deep review in the code, and IIUC, we can have a 
{{Cache<String, String>}}, that would mean:

{code} 
@@ -214,11 +214,11 @@ 
             if ( ptr.clazz == ByteBuffer.class ) 
             { 
                 // skip serialization if it is a bytebuffer 
- return ptr.directBuffer; 
+ return (String) ptr.directBuffer; 
             } 
{code} 

that is not correct
                
> Cache should allow key objects instead of plain string
> ------------------------------------------------------
>
>                 Key: DIRECTMEMORY-43
>                 URL: https://issues.apache.org/jira/browse/DIRECTMEMORY-43
>             Project: Apache DirectMemory
>          Issue Type: Improvement
>            Reporter: Maurizio Cucchiara
>            Assignee: Maurizio Cucchiara
>         Attachments: DIRECTMEMORY-43.patch, 
> DIRECTMEMORY-43_wider-type-inference_NOT-WORKING.patch, 
> patch.org.apache.directmemory.cache.zip
>
>
> See http://goo.gl/D4SRN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to