junrushao commented on PR #49: URL: https://github.com/apache/tvm-ffi/pull/49#issuecomment-3330955785
Updated the PR per offline discussion with @tqchen. To summarize the changes: - `prototype_py()` is no longer used in class creation; - No warnings are thrown when encountering unregistered classes to be consistent with pybind behavior; - `@c_class` is not used in this case, instead, we refactored existing `register_object(...)` behavior into `TypeMethod.as_callable(...)` and `TypeField.as_property(...)`, which is shared by both `register_object(...)` and `make_fallback_cls_for_type_index(...)`; - Clarified in the doc that the slow path `make_fallback_cls_for_type_index` is called only once for every missing type. CC: @tqchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
