tqchen commented on code in PR #49:
URL: https://github.com/apache/tvm-ffi/pull/49#discussion_r2378848919
##########
python/tvm_ffi/cython/type_info.pxi:
##########
@@ -109,6 +125,23 @@ class TypeInfo:
type_cls: Optional[type]
type_index: int
type_key: str
+ type_ancestors: list[int]
fields: list[TypeField]
methods: list[TypeMethod]
parent_type_info: Optional[TypeInfo]
+
+ def __post_init__(self):
+ cdef int parent_type_index
+ cdef str parent_type_key
+ if not self.type_ancestors:
+ return
+ parent_type_index = self.type_ancestors[-1]
+ parent_type_key = _type_index_to_key(parent_type_index)
+ self.parent_type_info =
_lookup_type_info_from_type_key(parent_type_key) # ensure parent is registered
Review Comment:
given behavior, likely need to rename to
_lookup_or_register_type_info_from_type_key
##########
python/tvm_ffi/cython/string.pxi:
##########
@@ -77,3 +77,5 @@ class Bytes(bytes, PyNativeObject):
_register_object_by_index(kTVMFFIBytes, Bytes)
+_register_object_by_index(kTVMFFIObject, Object)
+_register_object_by_index(kTVMFFIDevice, Device)
Review Comment:
device is not Object, need to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
