junrushao commented on code in PR #58:
URL: https://github.com/apache/tvm-ffi/pull/58#discussion_r2380689295
##########
python/tvm_ffi/cython/base.pxi:
##########
@@ -111,10 +111,8 @@ cdef extern from "tvm/ffi/c_api.h":
ctypedef void* TVMFFIObjectHandle
ctypedef struct TVMFFIObject:
- uint32_t strong_ref_count
- uint32_t weak_ref_count
+ uint64_t combined_ref_count
int32_t type_index
- int32_t __padding
Review Comment:
removing `__padding` makes it inconsistent with `c_api.h` - why do we want
to do so? it's okay for correctness though given Cython won't be using this
`ctypedef` as source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
