junrushao commented on code in PR #58:
URL: https://github.com/apache/tvm-ffi/pull/58#discussion_r2381027040
##########
docs/concepts/abi_overview.md:
##########
@@ -204,13 +203,14 @@ typedef struct TVMFFIObject {
`TVMFFIObject` defines a common 24-byte intrusive header that all in-memory
objects share:
-- `strong_ref_count` stores the strong atomic reference counter of the object.
-- `weak_ref_count` stores the weak atomic reference counter of the object.
+- `combined_ref_count` packs strong and weak reference counter of the object
into a single 64bit field
Review Comment:
See changes around `combined_refcount_` in this pytorch PR
https://github.com/pytorch/pytorch/pull/163394 for more details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
