tqchen commented on PR #230: URL: https://github.com/apache/tvm-ffi/pull/230#issuecomment-3532622669
Did one pass, main thing we should be careful is not using constness in cxx as a indicator of mutability(let us remove for now and discuss how to allow explicit annotation if needed). Others are mostly nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
