tqchen commented on code in PR #266:
URL: https://github.com/apache/tvm-ffi/pull/266#discussion_r2530508203
##########
include/tvm/ffi/function.h:
##########
@@ -145,14 +146,22 @@ namespace details {
template <typename TCallable>
class FunctionObjImpl : public FunctionObj {
public:
- using TStorage = std::remove_cv_t<std::remove_reference_t<TCallable>>;
Review Comment:
is this change intententionally? We want to explicitly avoid the case where
TCallable is a reference and resulted a shallow capture of the closure in
previous impl, would be good o confirm the impl logic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
