DarkSharpness commented on code in PR #266:
URL: https://github.com/apache/tvm-ffi/pull/266#discussion_r2531315012
##########
include/tvm/ffi/function.h:
##########
@@ -145,14 +146,22 @@ namespace details {
template <typename TCallable>
class FunctionObjImpl : public FunctionObj {
public:
- using TStorage = std::remove_cv_t<std::remove_reference_t<TCallable>>;
Review Comment:
`TCallable` cannot be a reference type in our code. The only usage is here:
`using ObjType = typename details::FunctionObjImpl<std::decay_t<TCallable>>;`
We manually decay it to value type, so we no longer need to remove cv ref
qualifier again in storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
