gemini-code-assist[bot] commented on code in PR #438: URL: https://github.com/apache/tvm-ffi/pull/438#discussion_r2792040790
########## include/tvm/ffi/extra/deep_copy.h: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +/*! + * \file tvm/ffi/extra/deep_copy.h + * \brief Reflection-based object copy utilities + */ +#ifndef TVM_FFI_EXTRA_DEEP_COPY_H_ +#define TVM_FFI_EXTRA_DEEP_COPY_H_ + +#include <tvm/ffi/any.h> +#include <tvm/ffi/extra/base.h> + +namespace tvm { +namespace ffi { + +/** + * \brief Deep copy an ffi::Any value. + * + * Recursively copies the value and all reachable objects in its object graph. + * Copy-constructible types with `ObjectDef` registration automatically support deep copy. + * Primitive types, strings, and bytes are returned as-is (they are immutable). + * Arrays and Maps are recursively deep copied. + * Objects without copy support are kept as shared references. Review Comment:  The documentation states that objects without copy support are kept as shared references. However, the implementation in `src/ffi/extra/deep_copy.cc` throws an error if an object is not copy-constructible. This is a significant discrepancy. The implementation's behavior of throwing an error seems more appropriate for a deep copy operation, as silently falling back to a shallow copy could lead to unexpected behavior. Please update the documentation to reflect that an error is thrown for non-copyable objects. ```c * Objects that are not copy-constructible will cause a runtime error. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
