tqchen commented on code in PR #438:
URL: https://github.com/apache/tvm-ffi/pull/438#discussion_r2806752339
##########
include/tvm/ffi/reflection/registry.h:
##########
@@ -460,6 +460,9 @@ struct init {
}
};
+/*! \brief Method name used for shallow copy registration. */
+inline constexpr const char* kShallowCopyMethodName = "__ffi_shallow_copy__";
Review Comment:
kInitMethodName is member of ObjectDef, for consistency maybe make it also
member?
Alterntaively, consider group these constants into struct or namespace like
`struct StaticTypeKey {`. Maybe TypeAttrName or `reflection::type_attr::`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
