gemini-code-assist[bot] commented on PR #446: URL: https://github.com/apache/tvm-ffi/pull/446#issuecomment-3902763365
## Summary of Changes Hello @junrushao, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the field reflection mechanism by introducing support for `DefaultFactory` functions. This change resolves a long-standing problem where mutable default values, when used with reflection, would lead to aliasing issues across different object instances. By allowing a callable factory to generate defaults, each instance now receives a unique, fresh default value, mirroring patterns seen in other languages like Python's dataclasses. The implementation involves updating core FFI structures, adding a new reflection trait, and centralizing the logic for applying default values. ### Highlights * **Default Factory Support**: Introduced `DefaultFactory` to allow callable functions for generating default values, addressing the issue of mutable default aliasing (e.g., for arrays or maps) by producing a fresh value each time. * **API Renaming and Flag Addition**: Renamed `TVMFFIFieldInfo::default_value` to `default_value_or_factory` to reflect its new dual purpose, and added `kTVMFFIFieldFlagBitMaskDefaultIsFactory` to indicate when the field holds a factory function. * **Centralized Default Resolution**: Added a new helper function `reflection::SetFieldToDefault` to encapsulate the logic for resolving default values, which now checks the `DefaultIsFactory` flag and invokes the factory if present. * **Binding Updates**: Propagated the field renaming and new flag definitions to Rust (`c_api.rs`) and Cython (`base.pxi`) bindings to maintain FFI compatibility. * **Comprehensive Testing**: Added a new test object `TestObjWithFactory` and associated unit tests to verify flag inspection, per-instance freshness of factory-generated defaults, and the correct behavior when an explicit value is provided. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Changelog</b></summary> * **include/tvm/ffi/c_api.h** * Added `kTVMFFIFieldFlagBitMaskDefaultIsFactory` flag to indicate a default value is a factory function. * Renamed `TVMFFIFieldInfo::default_value` to `default_value_or_factory` to accommodate both static values and factory functions. * **include/tvm/ffi/reflection/accessor.h** * Added `SetFieldToDefault` inline function to handle setting field defaults, including invoking factory functions when the `DefaultIsFactory` flag is set. * **include/tvm/ffi/reflection/creator.h** * Updated `ObjectCreator` to utilize the new `SetFieldToDefault` helper for applying default values. * **include/tvm/ffi/reflection/overload.h** * Updated `ObjectDef` to initialize `default_value_or_factory` instead of `default_value`. * **include/tvm/ffi/reflection/registry.h** * Modified `DefaultValue` trait to use the `default_value_or_factory` field. * Added `DefaultFactory` trait for registering callable functions as default value generators, setting the `DefaultIsFactory` flag. * **python/tvm_ffi/cython/base.pxi** * Added `kTVMFFIFieldFlagBitMaskDefaultIsFactory` to Cython bindings. * Renamed `default_value` to `default_value_or_factory` in Cython bindings. * **rust/tvm-ffi-sys/src/c_api.rs** * Renamed `default_value` to `default_value_or_factory` in Rust bindings, updating documentation accordingly. * **src/ffi/extra/reflection_extra.cc** * Included `tvm/ffi/reflection/accessor.h`. * Updated `MakeObjectFromPackedArgs` to use `reflection::SetFieldToDefault` for setting default values. * **src/ffi/extra/serialization.cc** * Updated `ObjectGraphDeserializer` to use `reflection::SetFieldToDefault` for setting default values during deserialization. * **src/ffi/object.cc** * Updated `TypeTable` to copy `default_value_or_factory` instead of `default_value`. * **tests/cpp/test_reflection.cc** * Included `tvm/ffi/container/array.h`. * Updated existing `FieldInfo` tests to reference `default_value_or_factory`. * Added `TestObjWithFactory` struct and its reflection definition. * Added `DefaultFactoryFlag` test to verify correct flag setting for factory and non-factory defaults. * Added `DefaultFactoryCreation` test to confirm per-instance freshness of factory-generated defaults. * Added `DefaultFactoryNotCalledWhenProvided` test to ensure factory is bypassed when an explicit value is given. </details> <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
