tqchen commented on code in PR #446:
URL: https://github.com/apache/tvm-ffi/pull/446#discussion_r2808237396
##########
include/tvm/ffi/c_api.h:
##########
@@ -861,6 +861,15 @@ typedef enum {
* This is an optional meta-data for structural eq/hash.
*/
kTVMFFIFieldFlagBitMaskSEqHashDef = 1 << 4,
+ /*!
+ * \brief The default_value_or_factory is a callable factory function () ->
Any.
+ *
+ * When this flag is set along with kTVMFFIFieldFlagBitMaskHasDefault,
+ * the default_value_or_factory field contains a Function that should be
+ * called with no arguments to produce the default value, rather than
+ * being used directly as the default value.
+ */
+ kTVMFFIFieldFlagBitMaskDefaultIsFactory = 1 << 5,
Review Comment:
kTVMFFIFieldFlagBitMaskDefaultFromFactory? Is is a bit ambiguious because
default value is not factory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
