Aharrypotter commented on PR #19515:
URL: https://github.com/apache/tvm/pull/19515#issuecomment-4408430782

   > Just curious can we completely move to new backend tests or do we still 
need to maintain old ones? We need to investigate if we can test ops such as 
Sequence, Attention, Quantization as they seems to be complicated.
   
   I checked Sequence, Attention, and Quantization locally.
   
   Quantization has a few passing cases, but enabling it cleanly would require 
very specific per-test include patterns. The broader `QuantizeLinear` / 
`DequantizeLinear` prefixes also pull in unsupported variants like blocked 
quantization, float8/float4, and int2/int4/uint2/uint4. So I think it is better 
to leave it for a follow-up PR.
   
   Attention also needs separate work: the ONNX backend tests use the standard 
Q/K/V Attention form, while the current Relax converter seems to support the 
older Microsoft-style packed-QKV path with `num_heads`.
   
   Sequence has similar issues, mostly around runtime sequence inputs, dynamic 
positions, `SequenceMap`/`Loop`, `ReverseSequence`, and `SplitToSequence`.
   
   Given that, I would keep this PR focused on the initial stable subset and 
track these categories as follow-up items.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to