Aharrypotter commented on PR #19515: URL: https://github.com/apache/tvm/pull/19515#issuecomment-4408526651
I think we can move in that direction, but probably not completely in one step. The ONNX Backend Tests are very useful for standard operator semantic coverage, and they can replace some duplicated hand-written semantic tests over time. However, `test_frontend_onnx.py` also contains TVM-specific importer tests that the ONNX Backend Tests do not directly cover, such as `keep_params_in_input`, initializer/runtime parameter handling, input/name sanitization, symbolic/dynamic shape handling, Relax IR structure checks, validation/error paths, and importer-to-legalization/compile integration cases. I agree that having two ONNX frontend test files could be confusing unless the boundary is clear. My intended split is that `test_frontend_onnx_backend.py` covers standard ONNX operator semantics with the official backend tests, while `test_frontend_onnx.py` keeps TVM-specific importer behavior and integration/regression tests. For this PR, I would keep the scope to landing the backend-test runner and the initial stable subset. Then, in a follow-up, we can audit `test_frontend_onnx.py`, migrate/delete duplicated semantic tests, and document where future ONNX frontend tests should go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
