gemini-code-assist[bot] commented on code in PR #19796:
URL: https://github.com/apache/tvm/pull/19796#discussion_r3421279059
##########
apps/cpp_rpc/CMakeLists.txt:
##########
@@ -61,6 +61,28 @@ if (BUILD_FOR_ANDROID AND USE_HEXAGON)
list(APPEND TVM_RPC_LINKER_LIBS cdsprpc log)
endif()
+if(USE_HEXAGON)
+ add_custom_command(TARGET tvm_rpc POST_BUILD
+ COMMAND ${CMAKE_COMMAND} -E copy_if_different
+
"${CMAKE_CURRENT_SOURCE_DIR}/../../src/backend/hexagon/runtime/rpc/android_bash.sh.template"
+ "${CMAKE_BINARY_DIR}/android_bash.sh.template"
+ )
+
+ if(BUILD_FOR_ANDROID)
+ add_custom_command(TARGET tvm_rpc POST_BUILD
+ COMMAND ${CMAKE_COMMAND} -E copy
+ $<TARGET_FILE:tvm_rpc>
+ "${CMAKE_BINARY_DIR}/tvm_rpc_android"
+ )
+ elseif(BUILD_FOR_HOST)
+ add_custom_command(TARGET tvm_rpc POST_BUILD
+ COMMAND ${CMAKE_COMMAND} -E copy
+ $<TARGET_FILE:tvm_rpc>
+ "${CMAKE_BINARY_DIR}/tvm_rpc_x86"
+ )
+ endif()
Review Comment:
For consistency and to avoid unnecessary timestamp updates (which can
trigger redundant downstream build steps or redeployments), consider using
`copy_if_different` instead of `copy` when copying the `tvm_rpc` executable.
```
if(BUILD_FOR_ANDROID)
add_custom_command(TARGET tvm_rpc POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy_if_different
$<TARGET_FILE:tvm_rpc>
"${CMAKE_BINARY_DIR}/tvm_rpc_android"
)
elseif(BUILD_FOR_HOST)
add_custom_command(TARGET tvm_rpc POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy_if_different
$<TARGET_FILE:tvm_rpc>
"${CMAKE_BINARY_DIR}/tvm_rpc_x86"
)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
