gemini-code-assist[bot] commented on code in PR #19796: URL: https://github.com/apache/tvm/pull/19796#discussion_r3421279067
########## tests/python/contrib/test_hexagon/README.md: ########## @@ -38,22 +38,10 @@ export HEXAGON_TOOLCHAIN="Path to Hexagon toolchain. It can be the Hexagon toolc You can find more information about downloading [Hexagon SDK](https://developer.qualcomm.com/software/hexagon-dsp-sdk). -First build Hexagon API application under `apps/hexagon_api`. This step will generate `tvm_rpc_android` and `libtvm_runtime.so` to run on Android. Also, it generates `libtvm_runtime.a` `libtvm_runtime.so`, `libhexagon_rpc_skel.so` and `libhexagon_rpc_sim.so` to run on Hexagon device or Hexagon simulator. - -```bash -cd apps/hexagon_api -mkdir build -cd build -cmake -DANDROID_ABI=arm64-v8a \ - -DANDROID_PLATFORM=android-28 \ - -DUSE_ANDROID_TOOLCHAIN="path to `android-ndk/build/cmake/android.toolchain.cmake` file" \ - -DUSE_HEXAGON_ARCH=v65|v66|v68|v69|v73|v75 \ - -DUSE_HEXAGON_SDK="path to Hexagon SDK" \ - -DUSE_HEXAGON_TOOLCHAIN="path to Hexagon toolchain `Tools` sub-directory which explained above" \ - -DUSE_OUTPUT_BINARY_DIR="path to `build/hexagon_api_output` which is a sub-directory of `tvm`" .. - -make -j2 -``` +First build the Hexagon RPC binaries. These are produced by TVM's CMake build +when Hexagon RPC support is enabled, and include `tvm_rpc_android`, +`tvm_rpc_x86`, `libhexagon_rpc_skel.so`, `libhexagon_rpc_sim.so`, and +`android_bash.sh.template`. Review Comment:  To make the instructions clearer for users, it would be helpful to explicitly mention the CMake flag (`-DUSE_HEXAGON_RPC=ON`) required to enable Hexagon RPC support. ```suggestion First build the Hexagon RPC binaries. These are produced by TVM's CMake build when Hexagon RPC support is enabled (by passing -DUSE_HEXAGON_RPC=ON to CMake), and include tvm_rpc_android, tvm_rpc_x86, libhexagon_rpc_skel.so, libhexagon_rpc_sim.so, and android_bash.sh.template. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
