tqchen commented on code in PR #19830: URL: https://github.com/apache/tvm/pull/19830#discussion_r3435874770
########## apps/cpp_rpc/CMakeLists.txt: ########## @@ -4,6 +4,7 @@ set(TVM_RPC_SOURCES main.cc rpc_env.cc rpc_server.cc + rpc_tracker.cc Review Comment: given tracker is somethng that do not have concern of portability(as it usually runs on a server with python), i think it is better to limit the on-tree implementation to python only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
