tqchen commented on PR #19750: URL: https://github.com/apache/tvm/pull/19750#issuecomment-4753523201
are we sure we want to have this behavior? The report is likely mostly come from fuzzer, and while Nan preserving is nice, having an explicit nan where check here will likely slow down the computation, i would rather have us to have less strict behavior while being efficient while leaving Nan handling as undefined behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
