cchung100m commented on PR #19750: URL: https://github.com/apache/tvm/pull/19750#issuecomment-4756855564
Thank you @tqchen for the thoughtful feedback, and thank you @tlopex for following up with #19847 to clean these up. You are right that wrapping these ops with an explicit `isnan` + `where`(and a full `sum(isnan)` pass for the reductions) pays a per-element cost on the common path to handle a corner case that, in practice, mostly shows up in fuzzer-generated inputs. Pushing that onto every elementwise/reduce result wasn't the right trade-off. I'll keep this in mind for future contributions and would be happy to help on the backend-side follow-up if that effort moves forward. Thanks again to both of you for the guidance and the correction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
