Hello,
I've just started using jQuery and Interface, fantastic bit of kit
I must say, it's a lot nicer than Yahoo UI's bloat.
I've come across a small bug in Interfaces idrag.js
regarding the onStop and onChange functionality - they didn't work!
I've attached a patch to fix the problem.
Cheers
- Mark Gibson
PS. Sorry if this isn't the right place, but I couldn't find a bug
list, SF style management, etc.
BTW. Is Interface accessible via anon CVS/SVN from anywhere?
--- interface/idrag.js 2006-09-04 21:20:00.000000000 +0100
+++ DL-trunk/js/jquery/interface/idrag.js 2006-09-06 13:06:39.103470200
+0100
@@ -297,9 +297,10 @@
jQuery.iDrag.helper.css('cursor', 'move');
}
+ nx = dragged.dragCfg.oR.x + ((!dragged.dragCfg.axis ||
dragged.dragCfg.axis == 'horizontally') ? (dragged.dragCfg.nx -
dragged.dragCfg.oC.x + dragged.dragCfg.diffX) : 0);
+ ny = dragged.dragCfg.oR.y + ((!dragged.dragCfg.axis ||
dragged.dragCfg.axis == 'vertically') ? (dragged.dragCfg.ny -
dragged.dragCfg.oC.y + dragged.dragCfg.diffY) : 0);
+
if (dragged.dragCfg.revert == false) {
- nx = dragged.dragCfg.oR.x + ((!dragged.dragCfg.axis ||
dragged.dragCfg.axis == 'horizontally') ? (dragged.dragCfg.nx -
dragged.dragCfg.oC.x + dragged.dragCfg.diffX) : 0);
- ny = dragged.dragCfg.oR.y + ((!dragged.dragCfg.axis ||
dragged.dragCfg.axis == 'vertically') ? (dragged.dragCfg.ny -
dragged.dragCfg.oC.y + dragged.dragCfg.diffY) : 0);
if (dragged.dragCfg.fx > 0 && nx !=
dragged.dragCfg.oC.x && ny != dragged.dragCfg.oC.y) {
x = new jQuery.fx(dragged,dragged.dragCfg.fx,
'left');
y = new jQuery.fx(dragged,dragged.dragCfg.fx,
'top');
@@ -351,8 +352,8 @@
if (dragged.dragCfg.onChange && (nx != dragged.dragCfg.oR.x ||
ny != dragged.dragCfg.oR.y)){
dragged.dragCfg.onChange.apply(dragged,
dragged.dragCfg.lastSi);
}
- if (dragged.dragCfg.onStart)
- dragged.dragCfg.onStart.apply(elm);
+ if (dragged.dragCfg.onStop)
+ dragged.dragCfg.onStop.apply(elm);
/*if (dragged && dragged.dragCfg.prot == false) {
if (dragged.dragCfg.ghosting == false) {
@@ -657,7 +658,7 @@
hpc : o.hpc ? o.hpc : false,
onDrag : {},
onStart : o.onStart &&
o.onStart.constructor == Function ? o.onStart : false,
- onStop : o.onStart &&
o.onStart.constructor == Function ? o.onStop : false,
+ onStop : o.onStop &&
o.onStop.constructor == Function ? o.onStop : false,
onChange : o.onChange &&
o.onChange.constructor == Function ? o.onChange : false,
axis :
/vertically|horizontally/.test(o.axis) ? o.axis : false
_______________________________________________
jQuery mailing list
[email protected]
http://jquery.com/discuss/
