Dmitry Rudakov wrote:
>
> Brice Burgess wrote:
>
>> Are you compressing (JS compressor, not gzip output) the combined
>> javascript output? I've played with similar techniques, and found
>> compressors and the capsulated function don't play well.
>>
>>
>
> Bruce, to successfully use JS compressor
> you need to include some semicolons to your source.
> To be exact - 5.
>
> herewith I send you these lines and their numbers in your source.
> All missing semicolons are marked with // !DR;
>
> #27 if(_o.trigger)$(this).jqmAddTrigger(_o.trigger);
> #28 });}; // !DR;
>
> #30 $.fn.jqmAddClose=function(e){hs(this,e,'jqmHide'); return this;}; //
> !DR;
> #31 $.fn.jqmAddTrigger=function(e){hs(this,e,'jqmShow'); return this;}; //
> !DR;
> #32 $.fn.jqmShow=function(t){return
> this.each(function(){if(!hash[this._jqm].a)$.jqm.open(this._jqm,t)});}; //
> !DR;
> #33 $.fn.jqmHide=function(t){return
> this.each(function(){if(hash[this._jqm].a)$.jqm.close(this._jqm,t)});}; //
> !DR;
>
>
> and 2 semicolons for jqDnR
>
> #11 $.fn.jqDrag=function(r){$.jqDnR.init(this,r,'d'); return this;}; // !DR;
> #12 $.fn.jqResize=function(r){$.jqDnR.init(this,r,'r'); return this;}; //
> !DR;
>
>
> After this your sources will be successfully packed and will work without
> any problems.
> I tested it.
>
> But to be honest the benefit of packing your sources is very close to zero!
> :)
> You made a very good job for "minimalism".
> But sometimes it could be useful... in case if your sources are included in
> one file which will be packed
> later. In this case these missing semicolons will become a big trouble.
> I would suggest that you include these semicolons your source (just 5
> bytes!) for further
> compatibility.
>
> thanks again for your work.
> Dmitry
>
Dmitry,
Aye see :) Thanks for noticing this. I will include your changes is
the next release. While packing jqModal is not the highest priority --
if it combined with other sources and packed, it should at least be
compatible.
Have a nice weeked,
~ Brice
_______________________________________________
jQuery mailing list
discuss@jquery.com
http://jquery.com/discuss/
