Hi all, On Tue, Oct 17, 2017 at 12:23 PM, Joerg Schilling < [email protected]> wrote:
> Jonathan Adams <[email protected]> wrote: > > [...] > > > > Also no code should be added that did not get > > > a code review, or if even just a single person mentions a veto. > > > > > Disagree. Some people are dicks. While code review is very important, > and > > code review from separate streams would be the best way to go, we can't > > have a single person saying that something should not happen because it > > might affect their system. If we allow this to happen then we will be > > causing the "distributions" to become more diverse, rather than sharing > any > > code, and it will be easier for those teams to never bother to push code > > back than deal with the hassle that 1 jerk might cause months of work to > be > > thrown away. > > Do you really support that a single person should be able to add code > without a > code review or after a code review did identify bugs? > I don't read Jonathan's reply that way - rather, I believe he means that there shouldn't be the possibility for any single person to hold up an integration against overwhelming agreement from other people (ok, that last part wasn't really there ... but that's my take on it). > This would be really sad news. > indeed, if that were his meaning, but I don't think it is. regards Michael -- Michael Schuster http://recursiveramblings.wordpress.com/ recursion, n: see 'recursion' ------------------------------------------ illumos-discuss Archives: https://illumos.topicbox.com/groups/discuss/discussions/T784fc87098d66577-Mb4d9dff5851ae7464104d7db Powered by Topicbox: https://topicbox.com
