MrSinatra;290075 Wrote: 
> i don't understand your point, you don't have much context to explain
> what you are saying.  and those are INTERNAL SC7 tags and users would
> not understand the implication of that.  can you please explain just
> what you mean?

That is what the code does.  That is the context.

If you wish to change the help documentation, it should match what the
code does.

. getting-artist-for-album-display
.   if ALBUMARTIST return ALBUMARTIST
.   if bandtag and BAND return BAND
.   if !COMPILATION and !VA return list of ARTISTS (on all tracks)

etc.

You said that TPE1 (track artist) was checked first.  It is not.

ALBUMARTIST is.

Then BAND.

Then a variety of things dealing with VA stuff.

But the code checks ALBUMARTIST first.  Then BAND.

It is not TPE2.  This is only executed long after the file has been
scanned.  It affects all formats, not just MP3: ie, FLAC has no
commonly used tag called 'TPE2' but this will affect FLACs that have a
field named 'BAND'.

Again, this section of code does not have access to the names of the
tags (TPE1 or TPE2, etc), so it must be discussed in terms of the
internal names of the tags.  Saying it would return TPE2 is blatantly
wrong: it would return no such thing on WMA, FLAC, APE, OGG, WAv, AIFF,
etc.  It returns the BAND field, regardless of what the original tag
name was.

Saying that it uses TPE1, therefore is wrong on two counts: the code is
cross-format and FLAC does not have a TPE1 yet is still subject to the
behavior of this code.

It is also wrong because TPE1/ARTIST is not checked first.


-- 
snarlydwarf
------------------------------------------------------------------------
snarlydwarf's Profile: http://forums.slimdevices.com/member.php?userid=1179
View this thread: http://forums.slimdevices.com/showthread.php?t=46093

_______________________________________________
discuss mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/discuss

Reply via email to