On Thu, Jul 09, 2015 at 07:11:05AM -0700, Aaron Wolf wrote: > > On 07/09/2015 12:15 AM, Etienne wrote: > > Hello, > > > > I don't really know what you mean by "push to master" but I strongly > > advise about it.
I mean accept merge requests, after they have been reviewed. > > Actually nobody should push to master :) Master should be stable and tagged. This is not a bad idea. Until recently we were using "git flow", with the 'production' branch being the stable, tagged version, and 'master' being the branch where development work is merged in. I recently decided that the process is overkill, however. master can serve both purposes. We *could* tag versions that actually get deployed; but then, there is https://snowdrift.coop/dev/build, which does the same thing. The one thing lost is a digital signature of the tag, but I'm not sure why we want that anyway. It's not like end users are constantly downloading a version and running their own Snowdrifts (other than for development). Any thoughts, anybody? > > Yet, it's compatible with "everybody pushing", as long as they do that > > in a separate branch. The best way to go would be to review code before > > any merge, but it takes time. Without a solid team of reviewer, the > > validation process can really be frustrating and carry away volunteers. We do already have a team of reviewers who work pretty quickly. Currently, however, all they can do is review: they can't accept/merge. That's the part I'm interested in now. > > P.S. : hello folks, I'm tumulte. Python, PHP front-end programmer. > > Skilled enough in Python, PHP, JS. Sucks at software architecture. > > Pretty aware of solid QA process. Killer good at CSS/HTML5. Not too bad > > with design and UX. Awesome! Yes, as Aaron said, when we have finalized the design it would be great to have someone help out in building a nice implementation in CSS/HTML5. If you haven't already, you should join the design mailing list and participate there. :) https://lists.snowdrift.coop/mailman/listinfo/design
signature.asc
Description: Digital signature
_______________________________________________ Discuss mailing list [email protected] https://lists.snowdrift.coop/mailman/listinfo/discuss
