Hi Timothée, This is fantastic, thanks for sending this along! I'm a big fan of setting down ground rules for contributions up front; this makes the review & integration process much simpler on you. I would recommend going into some more depth on concrete details of what makes a good pull request - even simple things like 'maximum 400 lines at a time', or 'short functions' can really improve and streamline the collaboration process. Chapter 3 of the primer on code review I wrote for the Mozilla Science Lab goes into some more detail and sites a couple references (including Greg Wilson's own work on the topic): http://mozillascience.github.io/codeReview/contrib.html - let me know any questions!
On Mon, Mar 9, 2015 at 9:53 AM, Timothée Poisot <[email protected]> wrote: > Hi list, > > I am writing a set of guidelines that we will use in projects for the lab, > both for outside collaborators but also to have a sane basis for our work. > > Here it is as a gist: https://gist.github.com/tpoisot/9beac414179518ad10c5 > > I would really appreciate any feedback on it. If this is something you use > in your group, does it works well? > > t > > -- > Timothée Poisot, PhD > > Professeur adjoint > Département des sciences biologiques > Université de Montréal > > phone : 514 343-7691 > web : http://poisotlab.io > twitter: @PoisotLab > > > _______________________________________________ > Discuss mailing list > [email protected] > http://lists.software-carpentry.org/mailman/listinfo/discuss_lists. > software-carpentry.org -- Best Regards, Bill Mills Community Manager Mozilla Science Lab
_______________________________________________ Discuss mailing list [email protected] http://lists.software-carpentry.org/mailman/listinfo/discuss_lists.software-carpentry.org
