Relatedly, Fernando Perez has a web-page with some guidelines for code review, based on a process he picked up from Rob Knight:
http://fperez.org/py4science/code_reviews.html We've also experimented a bit with this format in our "Software Journal Club <https://github.com/uwescience/software-working-group/blob/master/JournalClub.md> " On Tue, Apr 11, 2017 at 10:56 AM, Abraham D. Flaxman <[email protected]> wrote: > Hi all, > > > > I adapted the approach described by Philip Guo in a CACM blog to do > regular code review about two years ago, and it seems to be going well. > Here is the article that got me started: http://pgbovine.net/CACM- > group-code-reviews.htm > > > > I also still have the slide deck handy that I used to get people going > with my modified version of his approach: https://www.dropbox.com/s/ > wq3egxt351akwdg/code%20review%20intro.pptx?dl=0 > > > > Good luck! > > --Abie > > > > > > *Abraham D. Flaxman* > > Assistant Professor > > Institute for Health Metrics and Evaluation | University of Washington > > 2301 5th Avenue, Suite 600 | Seattle, WA 98121| USA > > Tel: +1-206-897-2802 | Mobile: +1-412-726-0401 <(412)%20726-0401> | Fax: > +1-206-897-2899 UW | Campus Mailbox: 358210 > > [email protected] | http://healthmetricsandevaluation.org| > http://healthyalgorithms.com > > > > > > > > *From:* Discuss [mailto:[email protected]] *On > Behalf Of *Mateusz Kuzak > *Sent:* Tuesday, April 11, 2017 7:10 AM > *To:* [email protected] > *Subject:* Re: [Discuss] teaching code review - training materials? > > > > Hi all, > > > > I have not realised the attachments have been removed. The paper I > mentioned is: > > "Designing a Rubric for Feedback on Code Quality in Programming Courses" > > https://dl.acm.org/citation.cfm?id=2999555 > > > > unfortunately not open access, behind the paywall. > > > > best, > > Mateusz > > On 10 April 2017 at 22:42:14, Mateusz Kuzak ([email protected]) > wrote: > > Hi Sumana, > > > > Thank you for sharing this. I think you may find interesting a paper about > designing a rubric for code review (and a rubric itself, attaching both). > > Good luck with the workshop and I hope you will tell us how it went. > > > > best, > > Mateusz > > > > On 10 April 2017 at 22:31:17, Sumana Harihareswara ([email protected]) > wrote: > > Summary: links to training materials teaching people how to review code? > > I'm working on an in-person training workshop to teach developers in an > open source project how to review code. Specifically, my goal is to get > these developers more comfortable performing nonbinding code review, so > that 3 months after the training, at least half of them are consistently > reviewing others’ pull requests. I am attempting to design this > instruction in accordance with Software Carpentry standards. > > Of course some of the training's going to be specific to the project > we're working on, but I'd love any other example training materials from > other communities or courses. > > The start of a draft for my workshop (I need to do a concept map and > then rework this): > https://paper.dropbox.com/doc/PyCon-sprint-Code-review- > training-jCLQtc4G3O0z93bLGV56g > > examples of some past trainings I've led: > https://www.mediawiki.org/wiki/Code_review_management/July_2011_training > and https://www.mediawiki.org/wiki/Code_review_management/ > Aug_2011_training > > -- > Sumana Harihareswara > Changeset Consulting > http://changeset.nyc > _______________________________________________ > Discuss mailing list > [email protected] > http://lists.software-carpentry.org/listinfo/discuss > > > _______________________________________________ > Discuss mailing list > [email protected] > http://lists.software-carpentry.org/listinfo/discuss >
_______________________________________________ Discuss mailing list [email protected] http://lists.software-carpentry.org/listinfo/discuss
