On Wed, Oct 4, 2017 at 8:57 AM, Gerard Capes <[email protected]> wrote: > Dear Software Carpenters, > > I've had a few PRs open on SC lessons for around 2 weeks. Two of them have > not received any response at all. One of them had a brief conversation, > ending with me asking for clarification as to what edits would be required > to have the PR merged. > > Now I know the maintainers are volunteers (I am also a lesson maintainer), > and have other priorities, but it's frustrating to go to the bother of > submitting a PR only to get nothing of use back. > > So I'm asking two things: > > Should Software Carpentry have a response time, where a maintainer should > assign the PR within 2 days, or at least comment to indicate their expected > response time? This is the approach I have been taking, but I must concede > that I get far fewer PRs on the lesson I maintain. > What can PR submitters do in my situation?
I don't have too much to add on what April already wrote, but this is a perennial problem on volunteer-based projects, or even on project that have paid contributors (a few projects I work on have paid contributors, but who are still stretched too thin to always be timely in reviewing PRs). As such, I've had tasks that should have at most taken a few weeks take *months* just due to the lack of time on the part of people qualified to review my work. I have very mixed feelings about all this. I'm 100% in favor of a general requirement that all changes go through a review process. But perhaps there should be a time limit after which at least *trusted* contributors (by some measure) should be able to merge changes that at least haven't already received negative response. This can be problematic too though. Because sometimes no response just means literally no one else has seen it. It might be nice if GitHub had a way to loudly call attention to PRs that have yet to even be given a +1 or -1 by someone... _______________________________________________ Discuss mailing list [email protected] http://lists.software-carpentry.org/listinfo/discuss
