On 8/22/07, Jerome Louvel <[EMAIL PROTECTED]> wrote: > > Hi Alex, > > > In the end, when you add the server the domain name resolves > > to a single > > IP address that is the bind address for the server. My only > > suggestion is that > > if I can use a name to set the bind address I should be able > > to use the same > > name to restrict a VirtualHost instance to that same address. > > [...] > > > I don't see the issue with allowing > > VirtualHost.setServerAddress() to do the > > same a resolve a domain name to a numeric IP address. If you > > give it the > > wrong domain name that is the same error as giving it the > > wrong IP address. > > Ok, I understand your point of view. It makes sense but things are a little > more complex because the "serverAddress" property is actually a Regex > expression that will be matched against a numerical IP address. It would be > hard to automatically decode domain names from this regex into IP address.
Since I can do what I need with the current API we should just make sure this is clear in java doc. > Also, note that you don't have to restrict by "serverAddress", by default a > VirtualHost will accept any IP address. You could simply restrict by > "hostDomain" instead. That would mean that the virtual host would match any interface on which the request came and I wanted to restrict by interface. Since that mapping happens elsewhere, the result would be the same. Thanks for the patiences but I think you're right in that we don't need a change given the added internal complexity with regex.
