Had a look at this, and it would need a fair amount of refactoring to do this properly. The ColumnDecorator actually gets invoked in the Column class during the getValue() call. The Column class is created in the ColumnIterator, which is in turn created in the Row class, which is created in TableTag itself. So to sumarise, to subclass the existing TableTag to allow a new type of Decorator, we would also need to edit Column, ColumnIterator and Row, which seems a lot of work to me. I'm going to think on this a bit more and see if there is a simpler approach.
sam Quoting [EMAIL PROTECTED]: > Extending the existing display tag sounds like a good idea - I'll have a > poke > around the code and see what would need to be done. > > Quoting John York <[EMAIL PROTECTED]>: > > > I like the idea, but I think I would implement it as an additional taglib > > that could inherit from the existing display tag. I think this feature is > > beyond the scope of the current displaytag, so I'd rather not jumble in a > > bunch of logic in the core tag. We've already got way too much of that. > > I'd rather see us have to refactor a few things and make it possible to > > derive a new tag from the existing one. > > > > The only problem I see with this approach is that if we decide to do it > > again for some other functionality, now you won't be able to do both at > > the same time. Maybe there's some way to create more of a pluggable > > architecture that would allow us to add the chunks of functionality we > > need without adding in any unecessary overhead. > > > > John > > > > > > On Wed, 29 Oct 2003, [EMAIL PROTECTED] wrote: > > > > > I've actually had a better idea. Rather than changing the > ColumnDecorator > > > interface, how about we add another Decorator type - a ControlDecorator? > > The > > > ControlDecorator would create the form control, using the result of the > > > ColumnDecorator as the display? > > > > > > Quoting [EMAIL PROTECTED]: > > > > > > > I have been looking at adding some simple support to the Display Tag > > > > foreditable > > > > tables. My current idea is to extend the ColumnDecorator class's > > decorate > > > > method. Currently, the method just takes the object value. My proposed > > > > alteration would have the column name and row number passed in. This > > would > > > > allow > > > > a decorator to create a properly named form control. > > > > > > <snip> > > > > > > > > > sam > > > http://www.magpiebrain.com/ > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: SF.net Giveback Program. > > > Does SourceForge.net help you be more productive? Does it > > > help you create better code? SHARE THE LOVE, and help us help > > > YOU! Click Here: http://sourceforge.net/donate/ > > > _______________________________________________ > > > displaytag-devel mailing list > > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > > > > > > > -- > > John York > > Software Engineer > > CareerSite Corporation > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: SF.net Giveback Program. > > Does SourceForge.net help you be more productive? Does it > > help you create better code? SHARE THE LOVE, and help us help > > YOU! Click Here: http://sourceforge.net/donate/ > > _______________________________________________ > > displaytag-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > > > > > sam > http://www.magpiebrain.com/ > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > displaytag-devel mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/displaytag-devel > sam http://www.magpiebrain.com/ ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ displaytag-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-devel
