Can't set factory.requestHelper on a per-table basis
----------------------------------------------------
Key: DISPL-507
URL: http://jira.codehaus.org/browse/DISPL-507
Project: DisplayTag
Issue Type: Bug
Affects Versions: 1.1.1
Reporter: Mike Calmus
While trying to create a test case for DISPL-505, I attempted to create a table
using the following partial code:
<display:table name="test" id="table">
<display:setProperty name="factory.requestHelper"
value="org.displaytag.util.AddJunkRequestHelperFactory"/>
<display:column sortable="true" property="ant" />
</display:table>
However, because the RequestHelperFactory (and correspondingly the BaseHref)
are set in the initParameters method of TableTag which is called from the
doStartTag call which is called before any nested tags are called, the
setProperty call above has no real effect. The factory.requestHelper property
can as such only be set in the displaytag.properties file.
A fix for this could be tricky since any users extending TableTag could be
assuming these values are set in the call to doStartTag. A possible way to deal
with this is simply a documentation change indicating this property can not be
set at runtime. It might be additionally useful to have the SetProperty tag
throw an error if this (or any other values deemed appropriate) are set at
runtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
