[
http://jira.codehaus.org/browse/DISPL-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_119931
]
Eric Bouwers commented on DISPL-419:
------------------------------------
The following is a diff against r1132 of svn of the file
"displayTag/src/main/java/org/displaytag/render/HtmlTableWriter.java".
It is only a small change, based on the solution stated above.
1)
diff -u src/main/java/org/displaytag/render/HtmlTableWriter.java
src/main/java/org/displaytag/render/.svn/text-base/HtmlTableWriter.java.svn-base
--- src/main/java/org/displaytag/render/HtmlTableWriter.java 2008-01-15
09:20:08.000000000 +0100
+++
src/main/java/org/displaytag/render/.svn/text-base/HtmlTableWriter.java.svn-base
2008-01-15 09:09:58.000000000 +0100
@@ -557,9 +557,7 @@
}
else
{
- // dirParam = properties.getPaginationAscValue();
- dirParam =
SortOrderEnum.ASCENDING.equals(headerCell.getDefaultSortOrder())
- ? properties.getPaginationAscValue() :
properties.getPaginationDescValue();
+ dirParam = properties.getPaginationAscValue();
}
href.addParameter(properties.getPaginationSortDirectionParam(),
dirParam);
if (paginatedList.getSearchId() != null)
When this is applied to the head all tests still pass.
> column defaultorder="descending" not working in paginated list
> --------------------------------------------------------------
>
> Key: DISPL-419
> URL: http://jira.codehaus.org/browse/DISPL-419
> Project: DisplayTag
> Issue Type: Bug
> Components: HTML Generation
> Affects Versions: 1.1
> Reporter: juozas salna
>
> HtmlTableWriter.java
> line 473:
> dirParam = properties.getPaginationAscValue();
> this should look at HeaderCell.defautSortOrder
> or the same as a few lines above working on non paginated list.
> line 426:
> boolean nowOrderAscending = true;
> if (headerCell.getDefaultSortOrder() != null)
> {
> boolean sortAscending =
> SortOrderEnum.ASCENDING.equals(headerCell.getDefaultSortOrder());
> nowOrderAscending = headerCell.isAlreadySorted()
> ? !this.tableModel.isSortOrderAscending()
> : sortAscending;
> }
> else
> {
> nowOrderAscending = !(headerCell.isAlreadySorted() &&
> this.tableModel.isSortOrderAscending());
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
