[
http://jira.codehaus.org/browse/DISPL-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=129223#action_129223
]
Jamie Taylor commented on DISPL-419:
------------------------------------
I think it would be better to reverse the sense of that comparison, so that
ascending is the default order if none is specified. Like so:
dirParam =
SortOrderEnum.DESCENDING.equals(headerCell.getDefaultSortOrder())
? properties.getPaginationDescValue()
: properties.getPaginationAscValue();
> column defaultorder="descending" not working in paginated list
> --------------------------------------------------------------
>
> Key: DISPL-419
> URL: http://jira.codehaus.org/browse/DISPL-419
> Project: DisplayTag
> Issue Type: Bug
> Components: HTML Generation
> Affects Versions: 1.1
> Reporter: juozas salna
>
> HtmlTableWriter.java
> line 473:
> dirParam = properties.getPaginationAscValue();
> this should look at HeaderCell.defautSortOrder
> or the same as a few lines above working on non paginated list.
> line 426:
> boolean nowOrderAscending = true;
> if (headerCell.getDefaultSortOrder() != null)
> {
> boolean sortAscending =
> SortOrderEnum.ASCENDING.equals(headerCell.getDefaultSortOrder());
> nowOrderAscending = headerCell.isAlreadySorted()
> ? !this.tableModel.isSortOrderAscending()
> : sortAscending;
> }
> else
> {
> nowOrderAscending = !(headerCell.isAlreadySorted() &&
> this.tableModel.isSortOrderAscending());
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel
