HTML export and Excel Hssf export share too much code
-----------------------------------------------------

                 Key: DISPL-594
                 URL: http://jira.codehaus.org/browse/DISPL-594
             Project: DisplayTag
          Issue Type: Bug
          Components: Export, HTML Generation
    Affects Versions: 1.1.1
            Reporter: Michael Osipov
            Priority: Critical


I recently ran into some problems with the Excel ASCII export and had to switch 
to the POI (binary) export which resolved my problems.

Another issued popped up: When declaring maxWords or maxColumns on a column 
they are handled correctly in HTML. Using an export function would imply that 
this feature is ignored since this feature is only necessary in HTML. Doing an 
Excel export results in the same bevahior as in HTML which is incorrect.

I checked the code and noticed that HTML and Excel share the same base.
HTML: HTMLTableWriter => ... => TableWriterTemplate
Excel: HssfTableWriter => ... => TableWriterTemplate

This means that they share the implemented methods in the abstract class and 
share too much code, Excel output resebles the HTML one.

The codes needs to be more separated!

This bug is related to my other issue: DISPL-592

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to