[ 
http://jira.codehaus.org/browse/DISPL-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=173616#action_173616
 ] 

Lionel commented on DISPL-594:
------------------------------

sharing TableWriterTemplate prevents HssfTableWriter from beeing able to know 
the type of the value

TableWriterTemplate  adds the value using: 
writeColumnValue(struct.decoratedValue, struct.column);
As decoratedValue is a String, the "instanceof" checks done in HssfTableWriter 
.writeColumnValue() are always false, and the Cell value is always a 
HSSFRichTextString.

This is a major issue as no mathematical function work on the cells.

> HTML export and Excel Hssf export share too much code
> -----------------------------------------------------
>
>                 Key: DISPL-594
>                 URL: http://jira.codehaus.org/browse/DISPL-594
>             Project: DisplayTag
>          Issue Type: Bug
>          Components: Export, HTML Generation
>    Affects Versions: 1.1.1
>            Reporter: Michael Osipov
>            Priority: Critical
>
> I recently ran into some problems with the Excel ASCII export and had to 
> switch to the POI (binary) export which resolved my problems.
> Another issued popped up: When declaring maxWords or maxColumns on a column 
> they are handled correctly in HTML. Using an export function would imply that 
> this feature is ignored since this feature is only necessary in HTML. Doing 
> an Excel export results in the same bevahior as in HTML which is incorrect.
> I checked the code and noticed that HTML and Excel share the same base.
> HTML: HTMLTableWriter => ... => TableWriterTemplate
> Excel: HssfTableWriter => ... => TableWriterTemplate
> This means that they share the implemented methods in the abstract class and 
> share too much code, Excel output resebles the HTML one.
> The codes needs to be more separated!
> This bug is related to my other issue: DISPL-592

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and 
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today. 
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to