On Mon, Jan 29, 2018 at 12:02 PM, Henry Saputra <henry.sapu...@gmail.com> wrote:
> Just want to clarify, so issue #1068 is used to track PR #1069? > #1068 is for purely code movement to the given location. Since it is a code movement, it is a bit hard to send out a PR for review, instead I push a branch `BP-26/distributedlog_merge` and document the steps used for code movement. #1069 is the change based on #1068 to make those relocated modules compile and build in bookkeeper project. - Sijie > > On Sun, Jan 28, 2018 at 9:59 PM, Sijie Guo <guosi...@gmail.com> wrote: > > > Updates: > > > > I merged the corresponding modules into a bk branch. details are > described > > in https://github.com/apache/bookkeeper/issues/1068 > > > > A subsequent PR to integrate those modules with BK pom files. In this PR, > > this modules will not be built unless `-Pdistributedlog` is provided. > > https://github.com/apache/bookkeeper/pull/1069 > > > > Please help review it. > > > > - Sijie > > > > On Fri, Jan 26, 2018 at 11:00 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > > > This BP is accepted. see details at : https://github.com/apache/ > > > bookkeeper/pull/1025#issuecomment-360871025 > > > > > > I've updated the master ticket #1024 > > > <https://github.com/apache/bookkeeper/issues/1024> with corresponding > > sub > > > tasks. > > > > > > - Sijie > > > > > > On Mon, Jan 22, 2018 at 6:11 AM, Sijie Guo <guosi...@gmail.com> wrote: > > > > > >> > > >> > > >> On Mon, Jan 22, 2018 at 3:44 AM, Enrico Olivelli - Diennea < > > >> enrico.olive...@diennea.com> wrote: > > >> > > >>> Il giorno ven, 19/01/2018 alle 13.17 -0800, Sijie Guo ha scritto: > > >>> > > >>> Hi all, > > >>> > > >>> I started a BP for proposing merging distributedlog library as part > of > > >>> bookkeeper. So > > >>> > > >>> 1) bookkeeper has a higher level log api, provideing named logs over > > >>> numbered ledgers. it would make the usage of bookkeeper simpler and > > help > > >>> grow more usage in bookkeeper > > >>> > > >>> 2) it would make distributedlog library shipped as part of bookkeeper > > >>> release. It will make the users of distributedlog library easier, > > because > > >>> they just need install bookkeeper and use dlog api. An integrated > > release > > >>> procedure will provide better user experiences. > > >>> > > >>> Details are proposed in the BP pull request: > > >>> https://github.com/apache/bookkeeper/pull/1025 > > >>> > > >>> Please take a look. Comments are welcome. > > >>> > > >>> > > >>> (I have already voted a big +1 on GitHub) > > >>> > > >>> > > >>> Side question: > > >>> > > >>> Will the +1 on the Pull Request be valid as official "VOTE" or should > > we > > >>> start an email thread ? > > >>> > > >> > > >> > > >> Yes +1 / approve on the pull request is the vote for the new BP > > workflow. > > >> > > >> > > >>> > > >>> This is an important change, to me rules are not very clear with the > > new > > >>> github BP workflow, I knew on ASF it is important that all votes are > > done > > >>> by means of official mailing lists > > >>> > > >> > > >> ASF requires all the conversations recorded in the ASF mailing list, > > >> which all the github notifications are already sent and kept in > > issues@b.a.o > > >> mailing list. > > >> > > >> > > >>> > > >>> Enrico > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> - Sijie > > >>> > > >>> > > >>> -- > > >>> > > >>> Enrico Olivelli Software Development Manager @Diennea Tel.: (+39) > 0546 > > >>> 066100 - Int. 925 Viale G.Marconi 30/14 - 48018 Faenza (RA) MagNews - > > >>> E-mail Marketing Solutions http://www.magnews.it Diennea - Digital > > >>> Marketing Solutions http://www.diennea.com > > >>> > > >>> ________________________________ > > >>> > > >>> Iscriviti alla nostra newsletter per rimanere aggiornato su digital > ed > > >>> email marketing! http://www.magnews.it/newsletter/ > > >>> > > >>> The information in this email is confidential and may be legally > > >>> privileged. If you are not the intended recipient please notify the > > sender > > >>> immediately and destroy this email. Any unauthorized, direct or > > indirect, > > >>> disclosure, copying, storage, distribution or other use is strictly > > >>> forbidden. > > >>> > > >> > > >> > > > > > >
