> On Jul 4, 2017, at 11:53 PM, Nick Coghlan <ncogh...@gmail.com> wrote:
> 
> While it would definitely be useful to have a "check build
> consistency" tool that built wheel files via all defined paths and
> then used diffoscope to compare them, having such a tool available
> wouldn't be a prerequisite for PEP acceptance (just as having
> auditwheel available wasn't a requirement for accepting the manylinux1
> specification).



I’ve had a niggling feeling about this hook from the beginning, but I couldn’t 
quite put my finger on it until Nathaniel’s email made me realize it. I feel 
like this hook is really *only* useful for flit, and for other projects it is 
largely either going to be completely redundant or be an attractive nuisance 
that ends up only causing issues. It’s a pretty narrow use case where this hook 
is both able to do something AND doesn’t have the exact same requirements as 
build_sdist.

When I felt this was a more generic hook, I was OK with it, but I don’t think 
it’s a good idea now that I’ve thought on it more and it feels entirely 
ungeneric.

—
Donald Stufft



_______________________________________________
Distutils-SIG maillist  -  Distutils-SIG@python.org
https://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to