Hi!
I'm a little confused about practices of working with Trac in Django
community and decided to ask here.
First, some history:
Some time ago I made a patch for ticket 440
(http://code.djangoproject.com/ticket/440) introducing a new config
parameter for default charset. This parameter was used to decode string
data from forms before validation which was to fix this ticket. Also the
patch was fixing ticket 333 (http://code.djangoproject.com/ticket/333)
supplying this charset with the Content-Type header.
This patch never made it in code and not long ago Adrian fixed ticket
333 with another change that made the patch obsolete. However Adrian's
change fixes nicely only ticket 333 but breaks the way to fix 440 as I
intended.
Then I asked in ticket 333:
Adrian, some time ago I made a patch for ticket 440 introducing
DEFAULT_CHARSET set to 'utf-8'. I made it that way to use the charset
for decoding submitted text fields data. Now with integral
DEFAULT_MIME_TYPE it's a bit less reliable (and a bit more ugly :-) )
to parse out this 'utf-8' thing.
I can rework this whole thing to break DEFAULT_MIME_TYPE into
DEFAULT_CONTENT_TYPE and DEFAULT_CHARSET. Or I can just hardcode
'utf-8'. The latter is a sleeping bomb though... What do you like better?
And there is no answer.
So here are my questions:
- what is the best way to discuss decisions in tickets and proposing
patches? (I come from bugzilla.mozilla.org background where patches are
mainly discussed in bugs' comments)
- am I doing something wrong? If yes, please, tell me, I'll stop! :-)
