On 1/6/06, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > > If no one is using packages I'll just drop it. > > This is a bit easier said than done...The content-types table depends > on it. How about splitting this patch into several stages -- > > * Move sessions from core to django.contrib.sessions (and change dependencies) > * Remove Package model (and dependencies on it) > * Move sites from core to django.contrib.sites (and change dependencies) > * Move auth to django.contrib.admin (and change dependencies) > * Move contenttypes to django.contrib.contenttypes (and change dependencies) > * Change django-admin init to install sites, auth, sessions, contenttypes > * Add django-admin init-minimal
Should sites be installed by init? I think it's used rarely enough that it shouldn't. Also, I think init should install admin as well, but maybe there should be something like an init-noadmin command as well in that case. It'd be nice to remove a couple of steps from the tutorials (django-admin.py install admin, add django.contrib.admin to INSTALLED_APPS), but it's at the expense of people who don't want the admin, but *do* want sessions, auth, etc. > What did I miss? Just updating the settings template so sessions, contenttypes, etc are in INSTALLED_APPS by default. That's sort of implied in each individual model move though. > Because this is a multi-step change, and it's much more manageable > (and more easily understood) for commits to be as narrowly-focused as > possible, would you be interested in commit access on the > magic-removal branch? Let me know, and I can send you information > privately. Sounds good. > > contenttypes feels pretty core to me. I guess django doesn't really > > depend on it though. (although many apps do.) I think contenttypes > > should it go in django.contrib.core? Any preferences? > > Let's do django.contrib.contenttypes. The only parts that depend on it > are the admin log and any bits that relate an object to another object > + content type (such as django.contrib.comments, in which a comment is > related to a content_type_id and object_id). Ok. > > Also, should the table names stay the same? My vote is for changing > > them, and updating BackwardsIncompatibleChanges with insructions on > > how to rename them. > > I agree -- the table names should be changed. > I guess the final step is adding to BackwardsIncompatibleChanges then. Joseph
