On Mon, 2006-07-03 at 21:04 -0700, jws wrote: > I submitted a patch to the tracker some time ago that was never merged. > I'm unsure if there's some other community protocol for getting things > accepted that I need to follow. > > I've described the problem, submitted a complete, working patch, got > buy-in from Adrian in principle, and had at least one person comment on > the need for such functionality. > > Can I get someone to look at this again? > > http://code.djangoproject.com/ticket/470
Speaking only for myself here... I'm not against the patch in principle, but I haven't applied it when I've been doing runs through outstanding patches for a few reasons: (1) It's been closed twice; once each by Jacob and Adrian. Closing it or applying both make some sense to me, so I'm not about to go any further without some clarification. (2) It is in no way a showstopper. You can always work around this by using ALTER TABLE statements to add the DEFAULT clause if you really want it in the "initial SQL" files. So even the final comment is possible to set up (and in fact, that commenter was informed of the fact on #django). (3) The patch still needs some work. There is neither documentation nor test cases with it, so if I was to sit down and try to resolve this, it's still going to take a bit of time (not sure if documentation is required or not, but that will take some thinking to work out, too). Again, my personal way of working is that I tend to prioritise patches in my head with the ones that don't have workarounds or are core functionality or very, very common use cases near the top of the list. Easy or obviously correct fixes are next. Ticket #470 doesn't meet any of those criteria for me. I'm sure we'll get to it eventually, but for now not applying doesn't really have a huge impact on usability. Trac doesn't lose patches, so it's still there for review. And re-raising it isn't a bad thing either, since you might get some more feedback. But there are just under 100 patches in Trac at the moment, of which about 65 - 70 are potential "evaluate and resolve" cases (and that's not counting genuine showstopper bugs that don't have a proposed solution yet, which may justifiably jump the queue sometimes). We are going through them steadily (the number is well down in the past few weeks) and it has gotten a bit out of hand. But realise it does take more than just five minutes to evaluate a patch, even the most trivial ones, so please don't think you're being intentionally ignored. Best wishes, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers -~----------~----~----~----~------~----~------~--~---
