On 12/12/06, graham_king <[EMAIL PROTECTED]> wrote:
>
> Has anyone else had a chance to test this new SelectBox.js ?
I've just started using it. We have about 15 people using admin most
of the day.
> I would
> really appreciate if someone could drop this js into their app and take
> a look - I guarantee you faster select boxes and faster page load times
> on all your admin interface that uses the filter interface
....
> If just one person could give it a test, I think there's a good case
> for integrating it into the trunk.
There were a few things you changed that were actually
de-optimizations in favor of readability. None of them matter
anywhere near the O(n^2) you got rid of, but they do increase the O(n)
constant. :)
Specifically, things like this:
for (var i = 0, j = SelectBox.cache[id].length; i < j; i++) {
are now like this:
for( var i=0; i<elementsArray.length; i++ ) {
While the latter is doubtlessly more readable, the former avoids the
.length call on each loop. (JS doesn't optimize the bound checking.)
The reason I mention it is to ask whether you'd like me to tweak it
back?
I don't mean to spread FUD on it; the changes are definitely
improvements and I don't see a problem with them in general. I'll
report back after a few days on whether there were any issues for us
in live use.
-Jeremy
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
