On Thu, 2007-03-08 at 11:08 -0600, Jeremy Dunck wrote: > On 3/6/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > A bunch of them have subsequently been notated as waiting until after > > 0.96 or they are for another branch. Some others are not no-brainers, so > > require some thought and for a committer to have a block of time > > available to drop them in. > > I wonder if, due to patches getting out of sync with trunk, tickets > that have been "Ready for Checkin" for longer than x weeks should go > back to Accepted?
It hasn't been a problem so far -- even quite old patches can usually be salvaged without too much trouble. I probably average about a 50-50 balance between applying a patch unchanged and having to tweak it in some way at commit time anyway, so accommodating a slight drift between the source and the patch is the least we can do if we've let a patch sit. For things that are miles away from applying cleanly and at all complicated, they're going to be bounced back to "needs better patch", but, on the whole, there is some responsibility to being a committer: we're meant to be able to do some work on our own, which includes helping out people who've submitted patches that we've left lying for a little while. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
