This is a really great patch. I read the patch but have not attempted
to use yet. Here are a couple of thoughts:
- I think the patch file itself may be a little messed up. I see that
several of the files are repeated. I could just be reading it wrong.
- Big positive in that you documented it so well!
- I like the fact that it's simple to create your own thumbnail
classes if necessary.
- Squash, crop and thumbnail are all very useful and I think it's
great to have all these available.
- This syntax looks just fine:
<img src="{{ object.imagefield|thumbnail:"150x100" }}" />
However, this feels a little bit clunky:
{% with object.imagefield|thumbnail:"150x100" as thumb %}
<img src="{{ thumb.url }}" width="{{ thumb.thumbnail.size.0 }}"
height="{{ thumb.size.1 }}" />
{% endwith %}
What if we had a shortcut like this:
{{ object.imagefield|thumbnail_full_tag:"150X100" }}
Which would generate:
<img src="source/file" width="150" height="100" />
- Also, one thing that is nice in Nesh's version is that it is easy to
cache thumbnails in memory. I think this would be a nice & fairly
simple thing to add.
Once again, really nice work. I look forward to seeing this in
Django. I think it would be really really useful.
-Chris
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
