On Thu, May 17, Jacob Kaplan-Moss wrote:
> On 5/15/07, jedie <[EMAIL PROTECTED]> wrote:
> > Whats about INTERNAL_IPS [1] ?
> 
> I think you need to let this one go. Malcom's already given a -1 and
> no other developers stepped up with even a +0.

Malcolm only gave it -1 for a very specific reason, and that was:

On Mon, Apr 09, Malcolm Tredinnick wrote:
> The reason I originally closed that ticket as "wontfix" -- and I still
> think it's the right reasoning -- is because the debug traceback handler
> is not associated with whether or not the development server is running.

So I consider it valid to bring up other ideas.


After leaving this hang around in my head for a while, I'm

a) +0 for a combination of INTERNAL_IPS and a specific setting
b) +0.5 for a specific setting that lists the IPs that are allowed
   connect to the debugger.
c) +1 for the same as b) implemented in a contrib middleware.

My reason is:

During debugging, I often need to see attributes of data which are not
displayed, or the result of fuctions. Besides, it is a real good tool for
beginners. But I really don't want anybody else to be able to fiddle with
the debugger view. Thus, I really want to set which IP is allowed. Debugging
usually happens within a safe and controlled network, so I can trust the IP.

The traceback handler isn't something that has seen a lot of changes, so I
guess the maintenance for this would be minimal. A middleware would still be
a better separation.

Michael

-- 
noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg -
Tel +49-911-9352-0 - Fax +49-911-9352-100
http://www.noris.de - The IT-Outsourcing Company
 
Vorstand: Ingo Kraupa (Vorsitzender), Joachim Astel, Hansjochen Klenk - 
Vorsitzender des Aufsichtsrats: Stefan Schnabel - AG Nürnberg HRB 17689

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to