On Thu, 2007-06-07 at 20:42 -0400, Marty Alchin wrote:
> On 6/7/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote:
> > No dbsettings depend on SITE_ID, as far as I can see.
> 
> The most recent version takes the current Site into account, using a
> ForeignKey to contrib.sites.models.Site. It then uses
> Site.objects.get_current() to get the Site for its queries, and as far
> as I can tell from its code, get_current() uses settings.SITE_ID to
> retrieve that object.

Oh, sorry, you mean dbsettings, the third-party app, not as an
abbreviation and typo for database settings (internally in Django). My
error.

> 
> I do realize this wouldn't have any impact on the other Django-proper
> settings. But even just changing this one setting would (likely) have
> a substantial impact on dbsettings. But, since I haven't actually
> tried it, I may well be missing something.

Read the rest of the thread to see how we were discussing doing this.

I think it (dynamic site handling) is something that might have to
happen in one way or another at some point, so it might be worth
thinking about how you can handle it one day maybe. A hash table mapping
site value to the collection of settings, for example. If we ever make
SITE_ID's equivalent dynamic, it would have to be very low-cost to get
the current value anyway, so the extra hash de-reference wouldn't kill
performance in that case. Is that impossible?

Regards,
Malcolm




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to