On Mon, 2007-06-18 at 09:27 -0500, Tom Tobin wrote: > Context: > http://groups.google.com/group/django-developers/browse_thread/thread/cb0dd0b5ba0ffe11/ > > I would like to submit for (re-)appraisal ticket #1465, which > implements regular expression field lookups (``__regex`` and > ``__iregex``). A newly attached patch is up to date with trunk, and > additionally has both case-sensitive and case-insensitive matching > working for each of the supported database engines. Additionally, the > new patch does *not* implement the admin searching functionality which > was frowned upon during the last discussion of the code.
Wow. That's a tiny patch. Good. Makes it easy to review. Looks like you had fairly good support last time around, so this shouldn't be too painful. > The two issues I might see with the current patch are: > > 1) It does not include any tests. I'm quite willing to write them; > it's just a matter of *where* they might go. :-) Of the two primary > test locations, ``regressiontests`` seems wrong as this is not a fix > for an existing bug; ``modeltests``, on the other hand, does not have > a location where the entire current range of field lookups are tested. > (Maybe this, in itself, is something that should be created?) modeltests/lookup/models.py looks like the right location. Where possible, hanging extra tests off existing files is a good approach because every new test file we add requires another database flush and reload and all the other test setup stuff. It takes a long time to run the tests at the moment and when you're doing it a few dozen times a day, the extra time starts to add up. > 2) It lacks support for two of the included backends: ``oracle`` and > ``ado_mssql``. If developers using either of these backends are aware > of how to implement regular expression matching, feel free to ping me > and/or the ticket, and I'll gladly include the code. The ado_mssql backend is completely unsupported (we should probably think about removing it at some point), so I wouldn't worry about that. The existing oracle backend is also unsupported. Very shortly (maybe even today if things go smoothly), I'll merge the boulder-oracle sprint branch into trunk so that we will have a supported Oracle backend. Then the maintainers of that portion of the code should be able to help with the implementation there. Once we have Oracle merged, it will be at the point where it's very impractical to expect patch writers to have tested against each supported backend, because installing and running Oracle is non-trivial. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
