On Jul 27, 2:51 pm, Graham Dumpleton <[EMAIL PROTECTED]>
wrote:
> On Jul 27, 12:34 pm, SmileyChris <[EMAIL PROTECTED]> wrote:
>
> > Reading through the mod_wsgi docs [1], I came to a section explaining
> > a problem with Django's core HTTP handling (search for "SCRIPT_NAME").
>
> > I have reopened #285 [2] and attached a patch which seemingly fixes
> > this. Could I please have some people more expert than me check it out
> > and provide some feedback?
>
> > [1]http://code.google.com/p/modwsgi/wiki/IntegrationWithDjango
> > [2]http://code.djangoproject.com/ticket/285
>From memory, your patch to mod_python handler will possibly break
> things. This is because even when application is hosted at root of
> server, for certain setups path_info is not the whole URI but has a
> leading component missing because of how Apache matches URLs to
> resources.

I understand that. That's why I propose changing PATH_INFO to match
mod_python_request_object.uri. Nothing in the previous discussion has
brought up why this is a bad idea.
In fact, ModPythonRequest currently sets path = self._req.uri
currently anyway.

> There are also various other impacts on Django from making the changes
> which I cant remember right now.

I read through all other references to PATH_INFO in Django. Nothing
else which jumps out at me that would break.

Since I changed the url resolver to work with PATH_INFO rather than
request.path, it won't break reverse resolving even for Request
handlers which use SCRIPT_NAME.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to