On Thu, Jul 26, 2007 at 07:19:01PM +0200, Nicola Larosa wrote: > > People seem to forget that one of the key rules in any coding guidelines > > is "do what the existing code does" (see, e.g., the second section of > > PEP 8). Thus, our current standards are in not in conflict with PEP 8 or > > PEP 257. > > Are Django committers willing to accept patches that reformat lines within > 80 characters?
Would personally be somewhat opposed to such patches; while I agree with 80 lines, reformatting code has a nasty nack of making it a serious pita to deal with patches from before the reformat point. Why not just correct as we go? In other words, if I'm already modifying this spot, do the reformat for the sections being modified? Yes, slightly extra noise on the patch, but at least the patch has a chance in hell of applying- after unicode, already have gone through a pretty heavy set of updates, not particularly looking forward to another couple of hours correcting for bitrot :) ~harring
pgpYPBeC6ngOR.pgp
Description: PGP signature
