On 8/8/07, John-Scott <[EMAIL PROTECTED]> wrote: > > Hello all, > > I'm trying to integrate S3 support into my Django app using > http://code.djangoproject.com/wiki/AmazonSimpleStorageService for > now. > > I would like to improve the code so that it might be officially > integrated into Django at some point. The first obvious question: Is > this a feature that others would like to see, enough so to warrant > having this feature 'baked-in'? Or should I just keep my hacks to > myself? > > I want to rewrite the code so that it doesn't subclass FileField, as > it currently does, but instead adds or alters the parameters to > FileField which can then be inherited by ImageField. Currently, the > S3FileField subclasses FileField and then has to duplicate some of the > functionality of ImageField, so it's not very DRY. The options I want > to add to FileField would determine whether or not the file should be > stored on the filesystem (the default) or to S3, plus additional > options specific to S3 storage (bucket and key values, etc.). Obviousy > this would involve tinkering with Django's models code directly so I > want to solicit feedback from the Python/Django pros before I go down > this path.
My guess would be that the core team would never accept changes to the base fields which add provider (ie. Amazon) specific features. Things like that are better left in contrib. I would personally rather have an S3FileField. Of course, if you changed FileFIeld such that you could use it with *any* S3-style provider, by passing it the right data (maybe some callbacks, or something), that'd be cool. Jay P. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
