On Sun, Aug 12, 2007 at 09:20:06AM -0400, George Vilches wrote:
> Something that I found a little irksome while working on this is that 
> the DatabaseWrapper class for each backend doesn't inherit from some 
> logical parent.  I know that all the db-specific functionality is 
> wrapped by these classes, but there are things that are in each class 
> that are most definitely shared functionality, like the mechanism by 
> which util.CursorDebugWrapper is instantiated.

Might want to take a look at ticket 5106; was working on connection 
pooling earlier this week, but ran into the same "wow, backend code 
needs some serious refactoring"- will push the patch later today, but 
basically have shifted everything so that construction, inspection, 
and client bits all are bound to the actual database wrapper instance 
itself- via that, can use a generic connection pooler that just wraps 
the real db wrapper.  You would be able to do the same thing I 
suspect- just pick out the correct method, and insert the logging there.


~harring

Attachment: pgpuckveuhcDI.pgp
Description: PGP signature

Reply via email to